Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: resubmit Custom Processors documentation #17265

Merged
merged 1 commit into from Jun 12, 2023
Merged

docs: resubmit Custom Processors documentation #17265

merged 1 commit into from Jun 12, 2023

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jun 10, 2023 •
edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Refers #17225

#17076 (comment)

Is there anything you'd like reviewers to focus on?

No

@snitin315 snitin315 requested a review from a team as a code owner June 10, 2023 02:59
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 10, 2023
This was referenced Jun 10, 2023
Merged
Closed
amareshsm
amareshsm approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@amareshsm amareshsm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for 2nd review.

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 12, 2023
mdjermanovic
mdjermanovic approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, but I'm not sure if this should rather have been submitted by the original author of 94da96c (@btmills) so I'd like @nzakas to verify.

nzakas
nzakas approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are small enough that I think it's okay to merge.

@nzakas nzakas merged commit 1b217f8 into main Jun 12, 2023
17 checks passed
@nzakas nzakas deleted the docs/custom-processors-port branch June 12, 2023 18:02
btmills
btmills reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a ✅, in case that helps if there are any questions later.

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 10, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btmills btmills btmills left review comments

@nzakas nzakas nzakas approved these changes

@amareshsm amareshsm amareshsm approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@snitin315 @nzakas @btmills @amareshsm @mdjermanovic