Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Resubmit custom rules update docs #17273

Merged
merged 2 commits into from Jun 11, 2023

Conversation

bpmutter
Copy link
Contributor

@bpmutter bpmutter commented Jun 11, 2023

Done b/c need to have OSS license apply to them.

See #17225

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Resubmitted docs for custom rules updates, which were originally merged in #16906.

Is there anything you'd like reviewers to focus on?

Nothing in this PR has hasn't already been reviewed. Just copy-paste of files from #16906. Worth giving this a sanity check to make sure I didn't mess anything up though.

see also https://github.com/eslint/eslint/pull/17273/files#r1225856526

Done b/c need to have OSS license apply to them.

See eslint#17225
@bpmutter bpmutter requested a review from a team as a code owner June 11, 2023 15:51
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 11, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that in this file some URL slugs that weren't in the original PR (#16906) are updated here.

that must have been a change that happened to the migration guide since the custom rules page was merged. however, these new links all seem to be correct, so might as well keep in the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the fact that this particular file had some changes between the license change and d8e9887, so copy & paste from d8e9887 includes those changes.

Could you please undo those changes so that the diff for this file is the exact same as in d8e9887?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undone!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit b199295 into eslint:main Jun 11, 2023
17 checks passed
Copy link

@Leena8686 Leena8686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval is granted for the resubmit of custom rules update docs. Thanks

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 9, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants