Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FlatESLint#getRulesMetaForResults shouldn't throw on unknown rules #17393

Merged
merged 2 commits into from Jul 21, 2023
Merged

fix: FlatESLint#getRulesMetaForResults shouldn't throw on unknown rules #17393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e47337e
fix: FlatESLint#getRulesMetaForResults shouldn't throw on unknown rules
mdjermanovic Jul 20, 2023
3317793
refactor test check
mdjermanovic Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/eslint/flat-eslint.js
View file
Open in desktop
Expand Up @@ -714,12 +714,10 @@ class FlatESLint {
}
const rule = getRuleFromConfig(ruleId, config);

// ensure the rule exists
if (!rule) {
throw new TypeError(`Could not find the rule "${ruleId}".`);
// ignore unknown rules
if (rule) {
resultRules.set(ruleId, rule);
}

resultRules.set(ruleId, rule);
}
}

Expand Down
36 changes: 36 additions & 0 deletions tests/lib/eslint/flat-eslint.js
View file
Open in desktop
Expand Up @@ -4478,6 +4478,42 @@ describe("FlatESLint", () => {

assert.deepStrictEqual(rulesMeta, { "no-var": coreRules.get("no-var").meta });
});

it("should return empty object if all messages are related to unknown rules", async () => {
const engine = new FlatESLint({
overrideConfigFile: true
});

const results = await engine.lintText("// eslint-disable-line foo, bar/baz, bar/baz/qux");

assert.strictEqual(results[0].messages.length, 3);
assert.strictEqual(results[0].messages[0].ruleId, "foo");
assert.strictEqual(results[0].messages[1].ruleId, "bar/baz");
assert.strictEqual(results[0].messages[2].ruleId, "bar/baz/qux");

const rulesMeta = engine.getRulesMetaForResults(results);

assert.strictEqual(Object.keys(rulesMeta).length, 0);
});

it("should return object with meta of known rules if some messages are related to unknown rules", async () => {
const engine = new FlatESLint({
overrideConfigFile: true,
overrideConfig: { rules: { "no-var": "warn" } }
});

const results = await engine.lintText("// eslint-disable-line foo, bar/baz, bar/baz/qux\nvar x;");

assert.strictEqual(results[0].messages.length, 4);
assert.strictEqual(results[0].messages[0].ruleId, "foo");
assert.strictEqual(results[0].messages[1].ruleId, "bar/baz");
assert.strictEqual(results[0].messages[2].ruleId, "bar/baz/qux");
assert.strictEqual(results[0].messages[3].ruleId, "no-var");

const rulesMeta = engine.getRulesMetaForResults(results);

assert.deepStrictEqual(rulesMeta, { "no-var": coreRules.get("no-var").meta });
});
});

describe("outputFixes()", () => {
Expand Down