Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix overlapping of open in playground button #17403

Merged
merged 3 commits into from Jul 25, 2023
Merged

docs: fix overlapping of open in playground button #17403

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e31ff02
docs: fix overlapping of open play button
Tanujkanti4441 Jul 22, 2023
5361e55
docs: update px to rem
Tanujkanti4441 Jul 23, 2023
9ec26c8
docs: open play btn style change for mobile size
Tanujkanti4441 Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/assets/scss/docs.scss
View file
Open in desktop
Expand Up @@ -166,6 +166,7 @@ pre[class*="language-"] {
position: fixed;
right: 50px;
bottom: 35px;
z-index: 1;
font-size: 1.5rem;
border-radius: 50%;
color: var(--body-background-color);
Expand Down
9 changes: 9 additions & 0 deletions docs/src/assets/scss/syntax-highlighter.scss
View file
Open in desktop
Expand Up @@ -120,3 +120,12 @@ pre[class*="language-"] {
width: 1.2em;
}
}

.incorrect,
.correct {
@media all and (min-width: 768px) {
pre.line-numbers-mode {
padding-bottom: 4rem;
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we give the above style to all devices? so that I will fix the mobile view look also?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good if we give the bottom padding for the code block as 4rem and the playground button bottom as 1rem

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!
WhatsApp Image 2023-07-24 at 10 57 04 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have kept the bottom position 1.5rem in PC size because it is touching the scrollbar in 1rem.

Screenshot 2023-07-24 231146