Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: no-misleading-character-class support v flag #17406

Merged
merged 3 commits into from Jul 25, 2023
Merged

feat: no-misleading-character-class support v flag #17406

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e01b93e
feat: `no-misleading-character-class` support `v` flag
ota-meshi Jul 23, 2023
4a92050
fix: lib/rules/utils/regular-expressions.js
ota-meshi Jul 23, 2023
90b618e
fix: iterateCharacterSequence
ota-meshi Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/rules/no-misleading-character-class.md
View file
Open in desktop
Expand Up @@ -79,6 +79,7 @@ Examples of **correct** code for this rule:

/^[abc]$/
/^[👍]$/u
/^[\q{👶🏻}]$/v
```

:::
Expand Down
5 changes: 4 additions & 1 deletion lib/rules/no-misleading-character-class.js
View file
Open in desktop
Expand Up @@ -144,7 +144,10 @@ module.exports = {
pattern,
0,
pattern.length,
flags.includes("u")
{
unicode: flags.includes("u"),
unicodeSets: flags.includes("v")
}
);
} catch {

Expand Down
2 changes: 1 addition & 1 deletion lib/rules/utils/regular-expressions.js
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ function isValidWithUnicodeFlag(ecmaVersion, pattern) {
});

try {
validator.validatePattern(pattern, void 0, void 0, /* uFlag = */ true);
validator.validatePattern(pattern, void 0, void 0, { unicode: /* uFlag = */ true });
} catch {
return false;
}
Expand Down
17 changes: 16 additions & 1 deletion tests/lib/rules/no-misleading-character-class.js
View file
Open in desktop
Expand Up @@ -70,7 +70,11 @@ ruleTester.run("no-misleading-character-class", rule, {
"var r = new RegExp('[Á] [ ');",
"var r = RegExp('{ [Á]', 'u');",
{ code: "var r = new globalThis.RegExp('[Á] [ ');", env: { es2020: true } },
{ code: "var r = globalThis.RegExp('{ [Á]', 'u');", env: { es2020: true } }
{ code: "var r = globalThis.RegExp('{ [Á]', 'u');", env: { es2020: true } },

// ES2024
{ code: "var r = /[👍]/v", parserOptions: { ecmaVersion: 2024 } },
{ code: String.raw`var r = /^[\q{👶🏻}]$/v`, parserOptions: { ecmaVersion: 2024 } }
],
invalid: [

Expand Down Expand Up @@ -620,6 +624,17 @@ ruleTester.run("no-misleading-character-class", rule, {
messageId: "zwj",
suggestions: null
}]
},


// ES2024
{
code: "var r = /[[👶🏻]]/v",
parserOptions: { ecmaVersion: 2024 },
errors: [{
messageId: "emojiModifier",
suggestions: null
}]
}
]
});
Expand Down