Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update no-promise-executor-return examples #17529

Merged
merged 2 commits into from Sep 6, 2023
Merged

docs: update no-promise-executor-return examples #17529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdbe967
docs: update `no-promise-executor-return` examples
snitin315 Sep 3, 2023
57dcb6c
docs: update example
snitin315 Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/src/rules/no-promise-executor-return.md
View file
Open in desktop
Expand Up @@ -38,6 +38,7 @@ Examples of **incorrect** code for this rule:

```js
/*eslint no-promise-executor-return: "error"*/
/*eslint-env es6*/

new Promise((resolve, reject) => {
if (someCondition) {
Expand Down Expand Up @@ -75,6 +76,7 @@ Examples of **correct** code for this rule:

```js
/*eslint no-promise-executor-return: "error"*/
/*eslint-env es6*/

// Turn return inline into two lines
new Promise((resolve, reject) => {
Expand Down Expand Up @@ -123,6 +125,7 @@ Examples of **correct** code for this rule with the `{ "allowVoid": true }` opti

```js
/*eslint no-promise-executor-return: ["error", { allowVoid: true }]*/
/*eslint-env es6*/

new Promise((resolve, reject) => {
if (someCondition) {
Expand Down