Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: report-unused-disable-directive to report unused eslint-enable #17611
feat: report-unused-disable-directive to report unused eslint-enable #17611
Changes from 9 commits
2bd9aed
c4b7dc9
26ea094
555ef98
de8f5df
5d3edd5
c50507d
864571f
c2fbe22
542b8a4
30e64b6
5be1604
424b6fb
8dc9b78
b87aee0
829a104
61808c6
5be3b34
bd42efa
c2d667b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to read this a few times to understand what
withoutRuleIdKey
meant. Is there a reason we can't just usenull
to indicate a directive without a rule ID?If not, could we rename this to
emptyRuleId
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment here explaining why we're going through the array backwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to match up with the code. If "it" refers to the disable directive, I don't see where it's being marked as used. Is
usedEnableDirectives
also used to track disable directives?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought "it" was referring to "an
eslint-enable
with the same ruleId" 😓. I'll change that comment.