Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add suggestions to no-console #17680

Merged
merged 12 commits into from Nov 17, 2023
Merged

feat: Add suggestions to no-console #17680

merged 12 commits into from Nov 17, 2023

Commits on Nov 7, 2023

  1. feat: Add suggestions to no-console 

    Fixes eslint#17493
    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    46a26e3 View commit details
    Browse the repository at this point in the history

  2. Fix method of when to show safe suggestions and fix tests.

    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f6c12cc View commit details
    Browse the repository at this point in the history

  3. improved formatting of tests with suggestions by breaking them into m… 

    …ultiple lines
    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    1d7dc3b View commit details
    Browse the repository at this point in the history

  4. Updated function name to canProvideSuggestions. Added better descript… 

    …ion for the function.
    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    384c381 View commit details
    Browse the repository at this point in the history

  5. Fixed code that fails when AST is not deep enough.

    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    bd8de82 View commit details
    Browse the repository at this point in the history

  6. Added suggestions:null for test cases that will not provide a suggest… 

    …ion.
    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c79833d View commit details
    Browse the repository at this point in the history

  7. test to make sure console statement with semicolon is removed via sug… 

    …gestion
    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    a74dc87 View commit details
    Browse the repository at this point in the history

  8. dont provide suggestions if removing console.log() will lead to ASI b… 

    …reaking
    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f112803 View commit details
    Browse the repository at this point in the history

  9. missing period

    @Rec0iL99
    Rec0iL99 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    1b1dea5 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. renamed regexps variable names for better understanding

    @Rec0iL99
    Rec0iL99 committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b997d58 View commit details
    Browse the repository at this point in the history

  2. updated passing in expressionstatement node instead of memberexpressi… 

    …on node to maybeAsiHazard
    @Rec0iL99
    Rec0iL99 committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f4e4d9a View commit details
    Browse the repository at this point in the history

  3. ++ or -- in the token before is not always safe.

    @Rec0iL99
    Rec0iL99 committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e12d3bc View commit details
    Browse the repository at this point in the history