Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove no-inner-declarations from eslint:recommended #17920

Merged
merged 1 commit into from
Dec 29, 2023
Merged

feat!: remove no-inner-declarations from eslint:recommended #17920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 17 additions & 19 deletions docs/src/_data/rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
{
"name": "no-constant-binary-expression",
"description": "Disallow expressions where the operation doesn't affect the value",
"recommended": false,
"recommended": true,
"fixable": false,
"hasSuggestions": false
},
Expand Down Expand Up @@ -193,7 +193,7 @@
{
"name": "no-inner-declarations",
"description": "Disallow variable or `function` declarations in nested blocks",
"recommended": true,
"recommended": false,
"fixable": false,
"hasSuggestions": false
},
Expand Down Expand Up @@ -354,7 +354,7 @@
{
"name": "no-unused-private-class-members",
"description": "Disallow unused private class members",
"recommended": false,
"recommended": true,
"fixable": false,
"hasSuggestions": false
},
Expand Down Expand Up @@ -652,7 +652,7 @@
"description": "Disallow `Array` constructors",
"recommended": false,
"fixable": false,
"hasSuggestions": false
"hasSuggestions": true
},
{
"name": "no-bitwise",
Expand Down Expand Up @@ -680,7 +680,7 @@
"description": "Disallow the use of `console`",
"recommended": false,
"fixable": false,
"hasSuggestions": false
"hasSuggestions": true
},
{
"name": "no-continue",
Expand Down Expand Up @@ -727,7 +727,7 @@
{
"name": "no-empty-static-block",
"description": "Disallow empty static blocks",
"recommended": false,
"recommended": true,
"fixable": false,
"hasSuggestions": false
},
Expand Down Expand Up @@ -1734,7 +1734,9 @@
"name": "no-new-symbol",
"replacedBy": [
"no-new-native-nonconstructor"
]
],
"fixable": false,
"hasSuggestions": false
},
{
"name": "no-path-concat",
Expand Down Expand Up @@ -1864,12 +1866,6 @@
"fixable": true,
"hasSuggestions": false
},
{
"name": "require-jsdoc",
"replacedBy": [],
"fixable": false,
"hasSuggestions": false
},
{
"name": "rest-spread-spacing",
"replacedBy": [],
Expand Down Expand Up @@ -1948,12 +1944,6 @@
"fixable": true,
"hasSuggestions": false
},
{
"name": "valid-jsdoc",
"replacedBy": [],
"fixable": true,
"hasSuggestions": false
},
{
"name": "wrap-iife",
"replacedBy": [],
Expand Down Expand Up @@ -2083,6 +2073,14 @@
"replacedBy": [
"spaced-comment"
]
},
{
"removed": "valid-jsdoc",
"replacedBy": []
},
{
"removed": "require-jsdoc",
"replacedBy": []
}
]
}
12 changes: 6 additions & 6 deletions docs/src/_data/rules_meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@
"type": "problem",
"docs": {
"description": "Disallow expressions where the operation doesn't affect the value",
"recommended": false,
"recommended": true,
"url": "https://eslint.org/docs/latest/rules/no-constant-binary-expression"
}
},
Expand Down Expand Up @@ -1038,7 +1038,7 @@
"type": "suggestion",
"docs": {
"description": "Disallow empty static blocks",
"recommended": false,
"recommended": true,
"url": "https://eslint.org/docs/latest/rules/no-empty-static-block"
}
},
Expand Down Expand Up @@ -1118,7 +1118,7 @@
"type": "suggestion",
"docs": {
"description": "Disallow unnecessary semicolons",
"recommended": true,
"recommended": false,
"url": "https://eslint.org/docs/latest/rules/no-extra-semi"
},
"fixable": "code"
Expand Down Expand Up @@ -1203,7 +1203,7 @@
"type": "problem",
"docs": {
"description": "Disallow variable or `function` declarations in nested blocks",
"recommended": true,
"recommended": false,
"url": "https://eslint.org/docs/latest/rules/no-inner-declarations"
}
},
Expand Down Expand Up @@ -1331,7 +1331,7 @@
"type": "layout",
"docs": {
"description": "Disallow mixed spaces and tabs for indentation",
"recommended": true,
"recommended": false,
"url": "https://eslint.org/docs/latest/rules/no-mixed-spaces-and-tabs"
}
},
Expand Down Expand Up @@ -1942,7 +1942,7 @@
"type": "problem",
"docs": {
"description": "Disallow unused private class members",
"recommended": false,
"recommended": true,
"url": "https://eslint.org/docs/latest/rules/no-unused-private-class-members"
}
},
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/no-inner-declarations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ module.exports = {

docs: {
description: "Disallow variable or `function` declarations in nested blocks",
recommended: true,
recommended: false,
url: "https://eslint.org/docs/latest/rules/no-inner-declarations"
},

Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-eslint/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ const jsConfigs = [js.configs.recommended, {
"no-extra-semi": "error",
"no-floating-decimal": "error",
"no-implied-eval": "error",
"no-inner-declarations": "error",
"no-invalid-this": "error",
"no-iterator": "error",
"no-label-var": "error",
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-eslint/eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ module.exports = {
"no-extra-semi": "error",
"no-floating-decimal": "error",
"no-implied-eval": "error",
"no-inner-declarations": "error",
"no-invalid-this": "error",
"no-iterator": "error",
"no-label-var": "error",
Expand Down
1 change: 0 additions & 1 deletion packages/js/src/configs/eslint-recommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ module.exports = Object.freeze({
"no-func-assign": "error",
"no-global-assign": "error",
"no-import-assign": "error",
"no-inner-declarations": "error",
"no-invalid-regexp": "error",
"no-irregular-whitespace": "error",
"no-loss-of-precision": "error",
Expand Down