New: Enhanced local plugin resolution. (fixes #3458) #4735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing presets sometimes it is desirable to include plugins as dependencies, since the preset may be explicitly for that dependency and that means one less thing users need to include and it offers an easy way to pin versions of a plugin with your preset. Unfortunately, the default `eslint` behavior is incapable of loading these local-style plugins for a couple of reasons: * `require` only resolves things relative to local eslint installation, * absolute paths are not supported, * developers don't want any code in `preset` definition files. So with all those caveats in mind, the behavior has been altered to simply start the preset resolution process at the _caller_'s module (i.e. the preset) instead of the _callee_'s module (i.e. `eslint`).
izaakschroeder
force-pushed
the
resolver-tweaks
branch
from
11dc566
to
9832120
Compare
izaakschroeder
changed the title
|
This doesn’t address the problem of version conflicts of the same plugin used in multiple shareable configs. |
|
Thanks @izaakschroeder. As @lo1tuma pointed out, if the problem was simply using different module resolution, we would have already made such a change. As it is, this change would only serve to confuse people in the case of multiple installed plugins with the same name. As such, we cannot merge this. Please see the original issue for details. |
|
Closing based on the above feedback. |
|
Sorry for the delay; been a busy holiday. I will try and look into this more when I have time. You are right to raise those concerns and I'm not sure how best to approach them at the moment. Thanks for the feedback guys! 😄 |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing presets sometimes it is desirable to include plugins as dependencies, since the preset may be explicitly for that dependency and that means one less thing users need to include and it offers an easy way to pin versions of a plugin with your preset. Unfortunately, the default
eslintbehavior is incapable of loading these local-style plugins for a couple of reasons:requireonly resolves things relative to local eslint installation,presetdefinition files.So with all those caveats in mind, the behavior has been altered to simply start the preset resolution process at the caller's module (i.e. the preset) instead of the callee's module (i.e.
eslint).This fixes #3458.