Fix: no-extra-parens ExpressionStatement restricted prods (fixes #4902) #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // special cases | ||
| "(a + b) * (c + d) == e", |
There was a problem hiding this comment.
This is only removed because it's not a special case and it's already covered by two separate tests above.
|
I wonder if this should be marked as breaking due to |
|
@ilyavolodin why would that be breaking? |
|
It shouldn't be a breaking change. The rule is now making strictly fewer reports. |
|
Before |
|
Even the other way around (if it was reporting things that it previously wasn't) would not necessarily be breaking. It's not breaking if the user asked for those errors but was not getting them. |
|
Yeah, this was a bug plain and simple, I don't see any breaking change here. |
nzakas
added a commit
that referenced
this pull request
Jan 11, 2016
Fix: no-extra-parens ExpressionStatement restricted prods (fixes #4902)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4902.