Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update: align argument for indent VariableDeclarator(fixes #8976) #9627

Closed
wants to merge 2 commits into from
Closed

WIP: Update: align argument for indent VariableDeclarator(fixes #8976) #9627

wants to merge 2 commits into from

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Nov 15, 2017 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[x] Changes an existing rule (template)

What changes did you make? (Give an overview)
fixes #8976

Is there anything you'd like reviewers to focus on?

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint indent Relates to the `indent` rule rule Relates to ESLint's core rules labels Nov 15, 2017
@kaicataldo
Copy link
Member

Friendly ping. Anything you need help with to finish this up?

@aladdin-add
Copy link
Member Author

Sorry for the delay! I've been so busying these days, maybe need a few days to finish this.
Someone who can pick up this would be very appreciated!

@platinumazure platinumazure added do not merge This pull request should not be merged yet and removed do not merge This pull request should not be merged yet labels Mar 23, 2018
@aladdin-add aladdin-add changed the title wip: Update: align argument for indent VariableDeclarator(fixes #8976) WIP: Update: align argument for indent VariableDeclarator(fixes #8976) Apr 1, 2018
@not-an-aardvark
Copy link
Member

I know this is still a WIP, but I wonder if it would be possible to update the VariableDeclarator logic to use a similar mechanism to array elements, so 'align' would be like 'first'.

Listor
Listor reviewed Apr 11, 2018
View reviewed changes
Copy link

@Listor Listor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just guessing if I look at https://eslint.org/docs/developer-guide/contributing/pull-requests but I think it should be fix: linting error shouldn't it ?

@kaicataldo
Copy link
Member

@Listor the subsequent commits will all be squashed and merged, so the commit message only matters for the initial commit.

@Listor
Copy link

Listor commented Apr 12, 2018

@kaicataldo sure but the test for the commit-message is failing so I was assuming it is because of that.

@aladdin-add
Copy link
Member Author

Sorry, I don't have time to get this finished.please feel free to pick up if you're interested. ❤️

@aladdin-add aladdin-add closed this May 8, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Nov 5, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Listor Listor Listor left review comments

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint indent Relates to the `indent` rule rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

align argument for indent VariableDeclarator
5 participants
@aladdin-add @kaicataldo @not-an-aardvark @Listor @platinumazure