Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test built-in rule schema validation #15

Closed
mdjermanovic opened this issue Oct 26, 2020 · 2 comments · Fixed by #31
Closed

Test built-in rule schema validation #15

mdjermanovic opened this issue Oct 26, 2020 · 2 comments · Fixed by #31
Labels
accepted chore
Projects
Triage

Comments

@mdjermanovic
Copy link
Member

refs #14

ESLint should validate configuration for built-in rules, and throw if the configuration is invalid.

We had a regression described in eslint/eslint#13793, due to the lack of tests for this scenario.

An integration test has been added in the eslint/eslint repo (eslint/eslint#13794), but we should add some unit tests to this repository, too.
@mdjermanovic mdjermanovic mentioned this issue Oct 26, 2020
Merged
@nzakas nzakas added this to Needs Triage in Triage via automation Feb 18, 2021
@nzakas
Copy link
Member

nzakas commented Mar 10, 2021

@mdjermanovic do you have a plan for what to do here?

@nzakas nzakas moved this from Needs Triage to Evaluating in Triage Mar 10, 2021
@mdjermanovic
Copy link
Member Author

I'm working on this.

mdjermanovic added a commit that referenced this issue Mar 14, 2021
@mdjermanovic
Chore: add tests for built-in rules config schema validation (fixes #15)
7f9ae78
@mdjermanovic mdjermanovic mentioned this issue Mar 14, 2021
Merged
@mdjermanovic mdjermanovic moved this from Evaluating to Pull Request Opened in Triage Mar 14, 2021
Triage automation moved this from Pull Request Opened to Complete Mar 23, 2021
nzakas pushed a commit that referenced this issue Mar 23, 2021
@mdjermanovic
Chore: add tests for built-in rules config schema validation (fixes #15…
7c43d77 
…) (#31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted chore
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: add tests for built-in rules config schema validation (fixes #15) eslint/eslintrc
2 participants
@nzakas @mdjermanovic