Fix: validate schema for built-in rules #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
commented
Oct 26, 2020
| @@ -484,7 +486,7 @@ class CascadingConfigArrayFactory { | |||
|
|
|||
| // Validate rule settings and environments. | |||
| const validator = new ConfigValidator({ | |||
| builtInRules: configArrayFactory.builtInRules | |||
There was a problem hiding this comment.
configArrayFactory stores builtInRules in internalSlotsMap, so this was undefined.
btmills
approved these changes
Oct 26, 2020
9 tasks
|
Sure, but since there's no place to add the test at the moment in this repo, and this is going into today's patch release, I'd suggest we merge this as is today, and add tests in a follow-up. I tested this locally, and @btmills prepared an integration test that covers this in eslint/eslint#13794 |
|
I'm okay with that so long as there's an issue open to track adding the tests. |
nzakas
approved these changes
Oct 26, 2020
|
Issue to track adding the tests: #15 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables validating configuration for built-in rules.
eslint/eslint#13793