Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests on Node.js v20 and v19 #571

Merged
merged 1 commit into from Apr 19, 2023
Merged

Conversation

snitin315
Copy link
Contributor

What changes did you make? (Give an overview)

  • run tests on Node.js v20
  • Remove Node v19 and v17 from matrix

Is there anything you'd like reviewers to focus on?

I feel it's fine to test on even node version only.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: snitin315 / name: Nitin Kumar (d447314)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@snitin315 snitin315 changed the title ci: run tests on Node.js v20 ci: run tests on Node.js v20 and v19 Apr 19, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants