feat: relative cache support #106
Conversation
|
Hi @CSchulz, thanks for the proposal. Please sign the CLA first, so that the team can review your proposal. |
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
nzakas
added
Initial Commenting
|
|
||
| ## Detailed Design | ||
|
|
||
| The LintResultCache takes a file path as parameter to find or store a file cache entry. |
There was a problem hiding this comment.
We need more details in this section. It should be written in such a way that someone else would be able to implement it. Please reference filenames, classes, etc., and what would have to change so we can get an idea of the implementation complexity. We'd like your recommendation for the best way to implement your suggestion. As-is, there's not enough detail here to comment on.
There was a problem hiding this comment.
@nzakas Can you help me out here? I am not so familar with the code to answer such questions in this detail level.
There was a problem hiding this comment.
@CSchulz I completely understand. Part of the RFC process is to have you get familiar with the code to see how plausible it is to implement (otherwise, we will have to do that for every RFC and there's just not enough time for that).
For this change, start by looking in lib/eslint/flat-eslint.js.
|
@CSchulz friendly reminder: there is a PR review for you to look into. Thanks. |
|
No updates, so closing. Please feel free to resubmit if you'd like to continue with this proposal. |
|
Is there a chance this might come back to life? My team is very interested in this. |
Summary
To be able to share the created eslint cache between different systems f.e. local machine and CI, there is a need for a relative path stored in the cache.
Related Issues
eslint/eslint#16493