Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs!: Docs information architecture refactor #97

Merged
merged 22 commits into from Dec 8, 2022

Conversation

bpmutter
Copy link
Contributor

Summary

This document contains proposed changes to the information architecture in the ESLint documentation website, https://eslint.org/docs.

On a high level, the proposed information architecture breaks the content into the following sections:

  • Use ESLint in Your Project: A refactor of the current User Guide
  • Extend ESLint: A refactor of the current Developer Guide, with some content moved to the section Maintain ESLint and Community Contributions
  • Maintain ESLint: Expansion of current Maintainer Guide, with some content taken from the current ‘Developer Guide’.
  • Community Contributions: Expansion of the current Contributing section of the Developer Guide.

Related Issues

eslint/eslint#16365

@eslint-github-bot
Copy link

Hi @bpmutter!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@bpmutter bpmutter changed the title 1st draft of RFP docs!: Docs information architecture refactor Oct 20, 2022
@eslint-github-bot
Copy link

Hi @bpmutter!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@bpmutter bpmutter marked this pull request as ready for review October 23, 2022 17:55
@nzakas nzakas added Initial Commenting This RFC is in the initial feedback stage and removed triage labels Oct 25, 2022
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I left a few comments.

It would also be helpful to include a simplified new documentation index that is just bullets and sub-bullets that shows the intended complete view of the left side of the docs. It’s a little difficult to envision it from the way this is structured currently.

@bpmutter
Copy link
Contributor Author

t would also be helpful to include a simplified new documentation index that is just bullets and sub-bullets that shows the intended complete view of the left side of the docs. It’s a little difficult to envision it from the way this is structured currently.

sure will add

@bpmutter
Copy link
Contributor Author

@nzakas responded to and implemented your feedback!

@nzakas
Copy link
Member

nzakas commented Oct 27, 2022

@bpmutter Hmmm, I’m not seeing any changes, did you push your latest commit?

@bpmutter
Copy link
Contributor Author

bpmutter commented Oct 28, 2022

@bpmutter Hmmm, I’m not seeing any changes, did you push your latest commit?

@nzakas sorry, didn't push yesterday. just did now. you can find the content there.

@bpmutter
Copy link
Contributor Author

@mdjermanovic responded to your feedback!

bpmutter and others added 2 commits November 15, 2022 21:39
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@nzakas nzakas added the tsc agenda Topic for discussion at next TSC meeting label Nov 16, 2022
@nzakas
Copy link
Member

nzakas commented Nov 16, 2022

TSC Summary: The last point to address here is how to move forward with URL structure. Possible options are 1) persona/action such as users/configure, 2) use case/action such as use/configure, 3) using/configuring

TSC Question: Which format do we want to use?

@mdjermanovic
Copy link
Member

In yesterday's TSC meeting we agreed to use /:verb/:subject for the URL format. In the options above, that's "2) use case/action such as use/configure".

If any path looks weird with this format, we can consider changing its URL by changing the :subject part (e.g., /integrate/nodejs-api could be /integrate/using-api), or by inserting /learn/ in the middle (e.g., contribute/architecture could be contribute/learn/architecture), or in some other way so that it reads better.

@mdjermanovic mdjermanovic removed the tsc agenda Topic for discussion at next TSC meeting label Nov 18, 2022
@bpmutter
Copy link
Contributor Author

In yesterday's TSC meeting we agreed to use /:verb/:subject for the URL format. In the options above, that's "2) use case/action such as use/configure".

thank you for the update! i'll update the URL paths to follow this pattern. will let the TSC know when that's done.

@bpmutter
Copy link
Contributor Author

ok, @nzakas i believe i have updated the URL paths in all parts where it was necessary. also did final review for copy changes, and everything seems to be ready for (final?) re-review.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are in pretty good shape now. Moving to final commenting.

@nzakas nzakas added Final Commenting This RFC is in the final week of commenting and removed Initial Commenting This RFC is in the initial feedback stage labels Nov 23, 2022
bpmutter and others added 5 commits December 5, 2022 20:34
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@bpmutter bpmutter requested review from mdjermanovic and removed request for btmills December 6, 2022 02:03
@bpmutter
Copy link
Contributor Author

bpmutter commented Dec 6, 2022

@mdjermanovic ready for re-review

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great idea to reorient around the core personas and split the Developer Guide into Contribute to ESLint and Extend ESLint.

@nzakas
Copy link
Member

nzakas commented Dec 8, 2022

All right, it looks like we are ready to move forward with this. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Commenting This RFC is in the final week of commenting
Projects
None yet
4 participants