Update netlify python version #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesserockz
force-pushed
the
netlify-python
branch
from
09ee9ca
to
fb20d4a
Compare
frenck
approved these changes
Jul 12, 2021
|
I think this PR broke the logo in the top-left corner. It doesn't show up and the linked URL gives a 404. It still worked for #1299 (see the deploy preview), and I can't imagine any of the other commits in between breaking it. Haven't looked into why it's broken though. |
|
Oh, good find. Will take a look. Thanks |
|
So I just tried locally with the dockerfile and python 3.9 works fine and 3.8 doesnt (which netlify uses) 🤦♂️ |
|
So unrelated to this change, just bad timing |
|
Ah, unlucky coincidence. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is required to update the build image used on Netlify
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
nextis for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created againstcurrent./index.rstwhen creating new documents for new components or cookbook.