-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telnet + wrench #6717
base: dev
Are you sure you want to change the base?
telnet + wrench #6717
Conversation
Hey there @apbodrov, CODEOWNERS = ["@apbodrov"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6717 +/- ##
======================================
Coverage ? 54.24%
======================================
Files ? 50
Lines ? 9581
Branches ? 1688
======================================
Hits ? 5197
Misses ? 4060
Partials ? 324 ☔ View full report in Codecov by Sentry. |
This is very niche and I think it should just live as an external_component |
This is the same SSH (It’s hard to call it niche), only for the poor. I want to implement through this interface such things as configuration in runtime, and such commands as, for example, |
I have no doubts that it could be useful to you and I know what telnet and SSH are. I am saying this in the context of having a telnet server available on a ESPHome device. We are happy to accommodate smaller core changes that would he helpful to an external component as long as they do not interfere with normal usage. |
What does this implement/fix?
Implementation of telnet cli
Types of changes
Related issue or feature (if applicable): part of esphome/feature-requests#2707
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: