Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell.info: respect shell verbosity #148

Merged
merged 1 commit into from
Jan 19, 2023
Merged

shell.info: respect shell verbosity #148

merged 1 commit into from
Jan 19, 2023

Conversation

utkarshgupta137
Copy link
Contributor

Fixes #138

@qryxip
Copy link
Collaborator

qryxip commented Jan 19, 2023

I think Shell already contains the --quiet flag.

Seeing Shell::warn implementation, It seems I wrote <Shell as crate::ShellExt>::info wrongly.

@utkarshgupta137
Copy link
Contributor Author

I think Shell already contains the --quiet flag.

Seeing Shell::warn implementation, It seems I wrote <Shell as crate::ShellExt>::info wrongly.

I somehow missed the verbosity method. That simplifies it a lot!

@utkarshgupta137 utkarshgupta137 changed the title Respect quiet arg for shell.info shell.info: respect shell verbosity Jan 19, 2023
est31
est31 approved these changes Jan 19, 2023
View reviewed changes
src/lib.rs Show resolved Hide resolved
@est31 est31 merged commit 90c31b5 into est31:master Jan 19, 2023
@utkarshgupta137
Copy link
Contributor Author

@est31 When can we expect a release?

@est31
Copy link
Owner

est31 commented Jan 31, 2023

@utkarshgupta137 see #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@est31 est31 est31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor (cosmetic) - could Loading save analysis messages be suppressed?
3 participants
@utkarshgupta137 @qryxip @est31