Addition of generic registry #612
Conversation
|
Also interested in having this in. |
|
@johnmehan we would like to deploy a simple local Docker registry without auth. Would that also be supported? |
…repositories being defined in config
|
From my testing, it looks like this forces defining every source registry and will error out on any images are not from a registry in the list. It also forces adding creds to all of them. @johnmehan I've PR'd your repo with an additional modification to enable using anonymous copies (both on source and destination) and also without defining creds for everything. @towolf While waiting for this to be merged eventually I pushed an image to |
Added the ability to auth without creds and fixed forcing the source …
|
@InputObject2 I've merged your changes. Thanks! |
| registryClient registry.Client | ||
| imagePullSecretProvider secrets.ImagePullSecretsProvider | ||
| sourceRegistryClients []registry.Client | ||
| destinationRegistryClient registry.Client |
There was a problem hiding this comment.
Can we rename this to targetRegistryClient to stay consistent with the config?
Added a generic registry allowing k8s-image-swapper to be used with registries that use username/password.