Support dynamic import (take 2) #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2019
|
Please align to the current estree proposal: estree/estree#198 |
|
@michaelficarra, ah, thanks, I was not aware of that. Aligned with it now and added as a TODO item in the PR description that we should wait for estree/estree#198 to be merged. |
|
estree/estree#198 was merged now 😌 @michaelficarra, can we move forward? |
Co-Authored-By: Michael Ficarra <github@michael.ficarra.me>
|
@michaelficarra, addressed all your feedback now 😎 |
michaelficarra
approved these changes
Aug 13, 2019
|
Thank you for the contribution, @papandreou! |
bizob2828
pushed a commit
to Contrast-Security-OSS/escodegen
that referenced
this pull request
Apr 2, 2020
* feat: support dynamic import * Add a couple of tests * Align with estree/estree#198 * Update escodegen.js Co-Authored-By: Michael Ficarra <github@michael.ficarra.me> * Remove outdated "State 3" from comment * Add test of a SequenceExpression as a dynamic import source estools#395 (comment) * Properly parenthesize when used with a higher precedence operator estools#395 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for https://github.com/tc39/proposal-dynamic-import (stage 4)
Fixes #376
Based on #385, which didn't include tests, and the author has gone silent.
TODO: