Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic import #100

Merged
merged 5 commits into from
Aug 12, 2019
Merged

Support dynamic import #100

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
022f9ec
Add support for dynamic Import expressions. See https://tc39.github.i…
Munter Apr 7, 2019
24d206d
Added skipped failing tests for dynamic import. Tests depend on espre…
Munter Apr 7, 2019
83c058f
Update dynamic import test with literal parse tree instead of dependi…
Munter Apr 7, 2019
f5157e4
Align with estree/estree#198
papandreou Aug 5, 2019
2bf769f
Merge pull request #1 from papandreou/support-dynamic-import
Munter Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions estraverse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
GeneratorExpression: 'GeneratorExpression', // CAUTION: It's deferred to ES7.
Identifier: 'Identifier',
IfStatement: 'IfStatement',
Import: 'ImportExpression',
ImportDeclaration: 'ImportDeclaration',
ImportDefaultSpecifier: 'ImportDefaultSpecifier',
ImportNamespaceSpecifier: 'ImportNamespaceSpecifier',
Expand Down Expand Up @@ -182,6 +183,7 @@
GeneratorExpression: ['blocks', 'filter', 'body'], // CAUTION: It's deferred to ES7.
Identifier: [],
IfStatement: ['test', 'consequent', 'alternate'],
Import: ['argument'],
ImportDeclaration: ['specifiers', 'source'],
ImportDefaultSpecifier: ['local'],
ImportNamespaceSpecifier: ['local'],
Expand Down
30 changes: 30 additions & 0 deletions test/es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,36 @@ describe('import', function() {
});
});

describe.skip('dynamic import', function() {
Copy link

@papandreou papandreou Apr 7, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn’t you get these tests to work by putting in object literals with the ast instead of blocking on espree?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't tried that. I'll give it a go

it('expression pattern #1', function() {
const tree = espree(`import('rabbit-house')`, {
ecmaFeatures: {
modules: true
}
});

checkDump(Dumper.dump(tree), `
enter - Program
enter - ImportExpression
leave - Program
`);
});

it('expression pattern #1', function() {
const tree = espree(`import(\`module-\${foo}\`)`, {
ecmaFeatures: {
modules: true
}
});

checkDump(Dumper.dump(tree), `
enter - Program
enter - ImportExpression
leave - Program
`);
});
});

describe('pattern', function() {
it('assignment pattern#1', function() {
const tree = {
Expand Down