Add module-expression #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
approved these changes
Dec 16, 2020
| type: "ModuleExpression"; | ||
| body: Program; | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Consider add a note that the sourceType of body must be "module".
There was a problem hiding this comment.
We can probably subtype Program to a Module for that. But it's fine for experimental.
nzakas
approved these changes
Dec 16, 2020
|
babel/babel#12469 has been merged and Babel 7.13 has been released! Can we merge this? |
|
ping @RReverser |
RReverser
approved these changes
Feb 25, 2021
|
@nzakas Don't you think this will break losts of ESLint plugins? Many rule listen on |
|
Yes, that’s a good point, which is why we probably want to go with @RReverser’s suggestion in the final version: #238 (comment) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View Rendered Text
Adds spec for JS Module Blocks. (ref: babel/babel#12469 (comment))