Align decorators to 2021-12 spec #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
commented
Feb 9, 2022
| ## Used | ||
| ## AccessorProperty | ||
| ```js | ||
| interface AccessorProperty <: Node { |
There was a problem hiding this comment.
On AccessorProperty, an alternative design is to add accessor: boolean to PropertyDefinition. Babel introduced a new type so that we can support https://github.com/tc39/proposal-grouped-and-auto-accessors based on the new AST node type. See also discussions here.
There was a problem hiding this comment.
I think a new node type makes sense. 👍
nzakas
approved these changes
Feb 15, 2022
|
@RReverser can you take a look? |
|
Weird, I thought this Github status thing would show up to others automatically & limit notifications.
Anyway, sorry, but as a Ukrainian, I'm busy with other stuff and won't be looking at code in the nearest time. Feel free to proceed without me on any blockers. |
|
Oh damn. Take care @RReverser. We are all pulling for Ukraine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View Rendered Text
This PR aligns the decorators experimental AST to the latest proposal, which is asking for stage 3 advancement in March. The AST design is based on Babel's current implementation.