Skip to content

Commit

Permalink
Merge pull request ocaml#510 from shubhamkumar13/fix-typing-gadts-tes…
Browse files Browse the repository at this point in the history
…t-principality-and-gadts

Update a testcase in principality-and-gadts.ml to reflect changes in ocaml#9584
  • Loading branch information
ctk21 committed Mar 25, 2021
2 parents abbff11 + 2f66d3f commit c5f7152
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions testsuite/disabled
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ tests/lib-dynlink-private/'test.ml' with 1.2.1.2.8.19.1 (run)
tests/weak-ephe-final/'weaktest.ml' with 1 (native)
tests/weak-ephe-final/'weaktest.ml' with 2 (bytecode)

# TODO: something is bad in typing with gadts and effects
# (went wrong when this test was introduced in #1931)
tests/typing-gadts/'principality-and-gadts.ml' with 1 (expect)

# TODO: port the new Ephemeron C-api to multicore
# https://github.com/ocaml/ocaml/pull/676
ephe-c-api
Expand Down
2 changes: 1 addition & 1 deletion testsuite/tests/typing-gadts/principality-and-gadts.ml
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ val foo : string foo -> string = <fun>
Line 3, characters 29-34:
3 | | { x = (x : string); eq = Refl3 } -> x
^^^^^
Warning 18 [not-principal]: typing this pattern requires considering M.t and string as equal.
Warning 18 [not-principal]: typing this pattern requires considering M.t and N.t as equal.
But the knowledge of these types is not principal.
val foo : string foo -> string = <fun>
|}]
Expand Down

0 comments on commit c5f7152

Please sign in to comment.