Skip to content

Commit

Permalink
Fix E2E tests (#392)
Browse files Browse the repository at this point in the history
* Fix usage of demo account in dev and ci setup

* Use node v16 explicitly
  • Loading branch information
florimondmanca committed Aug 29, 2022
1 parent e2f24ee commit 7fb6ad0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Expand Up @@ -34,8 +34,9 @@ jobs:
python-version: "3.10"
cache: "pip"

- uses: actions/setup-node@v2
- uses: actions/setup-node@v3
with:
node-version: 16
cache: 'npm'
cache-dependency-path: client/package-lock.json

Expand Down
6 changes: 3 additions & 3 deletions client/src/tests/e2e/login.spec.ts
@@ -1,5 +1,5 @@
import { expect } from "@playwright/test";
import { TEST_EMAIL } from "./constants";
import { TEST_EMAIL, TEST_PASSWORD } from "./constants";
import { test } from "./fixtures";

test.describe("Login", () => {
Expand All @@ -21,8 +21,8 @@ test.describe("Login", () => {
expect(await email.inputValue()).toBe(TEST_EMAIL);

const password = page.locator("form [name=password]");
await password.fill("demo");
expect(await password.inputValue()).toBe("demo");
await password.fill(TEST_PASSWORD);
expect(await password.inputValue()).toBe(TEST_PASSWORD);

const button = page.locator("button[type='submit']");
const [request, response] = await Promise.all([
Expand Down

0 comments on commit 7fb6ad0

Please sign in to comment.