Fix redirect loop on home page #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrige un bug introduit par #398
PUBLIC_PAGESétait aussi utilisé par leauthGuardpour ne pas vérifier la présence de$usersur certaines pages.En le transformant en
STATIC_PAGES(qui exclut du SSR) et en en retiarnt/, la page d'accueil non-connectée souffre maintenant d'une 500 Redirect Loop.Pour l'instant j'utilise donc une nouvelle variable au nom peu élégant mais évocateur.
Je vais déployer sur staging pour vérifier, puis merger et déployer pour corriger le bug (hotfix).
Ce bug a pu apparaître car notre CI n'échoue toujours pas si les tests E2E sont HS. Or ils l'étaient sur #398 et je ne l'ai pas vu. Par ailleurs le comportement qui était sensé être corrigé par #392 en passant à Node v16 sur la CI semble être revenu...