Skip to content

Commit

Permalink
Fix deprecation comments from addressing var-naming work
Browse files Browse the repository at this point in the history
The deprecation tag/comment must to be followed by an empty line.

Signed-off-by: Ivan Valdes <ivan@vald.es>
  • Loading branch information
ivanvc committed Apr 24, 2024
1 parent 9027014 commit 242f5d6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions server/etcdserver/api/etcdhttp/health.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,11 @@ func (reg *CheckRegistry) RootPath() string {
}

// InstallHttpEndpoints installs the http handlers for the health checks.
//
// Deprecated: Please use (*CheckRegistry) InstallHTTPEndpoints instead.
//
//revive:disable:var-naming
//revive:disable-next-line:var-naming
func (reg *CheckRegistry) InstallHttpEndpoints(lg *zap.Logger, mux *http.ServeMux) {
//revive:enable:var-naming
reg.InstallHTTPEndpoints(lg, mux)
}

Expand Down
1 change: 1 addition & 0 deletions server/storage/datadir/datadir.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ func ToSnapDir(dataDir string) string {
}

// ToWalDir returns the directory path for the member's WAL.
//
// Deprecated: use ToWALDir instead.
//
//revive:disable-next-line:var-naming
Expand Down
1 change: 1 addition & 0 deletions server/storage/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ func CreateConfigChangeEnts(lg *zap.Logger, ids []uint64, self uint64, term, ind

// GetEffectiveNodeIdsFromWalEntries returns an ordered set of IDs included in the given snapshot and
// the entries.
//
// Deprecated: use GetEffectiveNodeIDsFromWALEntries instead.
//
//revive:disable-next-line:var-naming
Expand Down

0 comments on commit 242f5d6

Please sign in to comment.