New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Upgrade to use go.opentelemetry.io/otel@v1.2.0 #13498
Conversation
b0b0cc9
to
5e36bac
Compare
/cc @hexfusion @ptabor |
d8b752d
to
ccda592
Compare
Thanks for the PR does this change in grpc-go regarding unix sockets[1] affect us? [1] grpc/grpc-go#4817 |
Looks like there's already code in place to deal with the relative path case: https://github.com/etcd-io/etcd/blob/main/client/v3/internal/endpoint/endpoint.go#L103 |
try running scripts/fix.sh to cleanup the deps failing in static [1] [1] https://github.com/etcd-io/etcd/runs/4313064751?check_suite_focus=true |
c34369b
to
bf8b05e
Compare
@hexfusion thanks for the tip about |
once tests are green let's squash these commits please, thanks! |
Is it normal for some of these builds to take 30+ minutes to complete? |
looks like the tests are in a pending state might be some sort of throttling, but it is not expected. |
267a1e7
to
968abba
Compare
Have squashed this change into a single commit as requested. I've also moved |
Upgrading from v1.0.1. Upgrading related dependencies ------------------------------ The following dependencies also had to be upgraded: - go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.26.1 From v0.25.0. This gets rid of a transitive dependency on go.opentelemetry.io/otel@v1.0.1. - google.golang.org/genproto@v0.0.0-20211118181313-81c1377c94b1
968abba
to
71493bd
Compare
Amended the commit message and PR description as they both referenced a newer version that isn't part of the diff here. |
Looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @KushalP
Upgrading from v1.0.1.
Upgrading related dependencies
The following dependencies also had to be upgraded:
From v0.25.0. This gets rid of a transitive dependency on go.opentelemetry.io/otel@v1.0.1.