Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fixing dependencies that brake tests in go.1.15.15 #14075

Merged
merged 1 commit into from May 30, 2022

Conversation

lavacat
Copy link

@lavacat lavacat commented May 26, 2022

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@ahrtr
Copy link
Member

ahrtr commented May 26, 2022

Thanks @lavacat for the fix. Please breakdown this PR into two. The first is to fix the typos in clientv3/retry_interceptor_test.go, and the second one is to bump bbolt version.

We can get first one merged firstly, and ask for opinions from other maintainers as well for the second one.

- retry_interceptor_test causes:
clientv3/naming/grpc.go:25:2: module google.golang.org/grpc@latest found (v1.46.0),
but does not contain package google.golang.org/grpc/naming
etcd-io#12124
@lavacat lavacat force-pushed the release-3.4-go1.15.15-tests branch from e6be68d to ceed023 Compare May 30, 2022 19:09
@lavacat
Copy link
Author

lavacat commented May 30, 2022

@ahrtr updated pr with only retry_interceptor_test fix.

test (1.15.15, linux-amd64-fmt) is still failing with errors I can't reproduce locally using golang:1.15 docker image. I suspect there are some differences in my env and GitHub Actions ubuntu-latest image.

@ahrtr
Copy link
Member

ahrtr commented May 30, 2022

@ahrtr updated pr with only retry_interceptor_test fix.

test (1.15.15, linux-amd64-fmt) is still failing with errors I can't reproduce locally using golang:1.15 docker image. I suspect there are some differences in my env and GitHub Actions ubuntu-latest image.

Thanks. We can fix the other failures in a separate PR.

@ahrtr ahrtr merged commit c2c9e7d into etcd-io:release-3.4 May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants