Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update genproto dependency #16301

Closed
wants to merge 2 commits into from
Closed

Update genproto dependency #16301

wants to merge 2 commits into from

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jul 25, 2023

Updates to a version of genproto that splits out the generic api/rpc packages to avoid future "ambiguous imports" errors.

See googleapis/go-genproto#1015 for more details.

@ahrtr ahrtr marked this pull request as draft July 26, 2023 07:29
@liggitt
Copy link
Contributor Author

liggitt commented Aug 1, 2023

rebased

@liggitt
Use canonical package for grpc test types
de50734 
Signed-off-by: Jordan Liggitt <liggitt@google.com>
@liggitt
dependencies: bump genproto
6d95567 
./scripts/update_dep.sh google.golang.org/genproto latest
./scripts/update_dep.sh google.golang.org/grpc v1.57.0
./scripts/fix.sh

Signed-off-by: Jordan Liggitt <liggitt@google.com>
@ahrtr ahrtr mentioned this pull request Aug 1, 2023
Merged
@liggitt
Copy link
Contributor Author

liggitt commented Aug 1, 2023

Tests / test (linux-amd64-integration-2-cpu) (pull_request) Failing after 20m failure is a timeout:

integration/clientv3/examples (15m0.113s)

I can't reproduce this locally, ETCD_VERIFY=all go test -v -json ./integration/... -timeout=15m --race --cpu=2 -p=2 passes just fine

ok  	go.etcd.io/etcd/tests/v3/integration/clientv3/examples	3.093s

@liggitt
Copy link
Contributor Author

liggitt commented Aug 1, 2023

@ahrtr is the integration-2-cpu test timing out elsewhere, or is that specific to this PR? how close to the 15 minute timeout is it running normally when it passes in CI?

@ahrtr
Copy link
Member

ahrtr commented Aug 2, 2023

@ahrtr is the integration-2-cpu test timing out elsewhere, or is that specific to this PR? how close to the 15 minute timeout is it running normally when it passes in CI?

I think It has nothing to do with this PR. It should be just flaky test case. We can follow it separately.

@ahrtr
Copy link
Member

ahrtr commented Aug 2, 2023

Closing this PR since a similar PR #16338 has already been merged per your comment.

[Note: This PR was raised earlier than https://github.com//pull/16338] thx @liggitt

@ahrtr ahrtr closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liggitt @ahrtr