Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky: increase wait timeout in TestRevisionPause to solve flakiness issue #17621

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qincwang
Copy link

@qincwang qincwang commented Mar 21, 2024

fix flaky related to issue #17548
increased Recorder wait timeout in TestRevisionPause.go to be 10s to eliminate flakiness

@k8s-ci-robot
Copy link

Hi @qincwang. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qincwang qincwang changed the title bump up wait timeout to solve flakiness issue flaky: increase wait timeout in TestRevisionPause to solve flakiness issue Mar 21, 2024
@ivanvc
Copy link
Member

ivanvc commented Mar 21, 2024

Hi @qincwang, thanks for the pull request. I'd suggest seeing the result of running the tests with stress for this PR.

In the meanwhile, please ensure your commit is signed so the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

@serathius
Copy link
Member

serathius commented Mar 21, 2024

Can you use https://gist.github.com/liggitt/6a3a2217fa5f846b52519acfc0ffece0 to validate the PR helps with flaking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants