Test: add tools/rw-heatmaps & tools/testgrid-analysis to module_dirs

[tico88612]

Resolve #17760

[k8s-ci-robot]

Hi @tico88612. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmhbnz]

/ok-to-test

[tico88612]

Should I fix lint for this PR?

https://github.com/etcd-io/etcd/actions/runs/8635285626/job/23677581680?pr=17770#step:10:58

[ivanvc]

@tico88612, I feel like this is a reasonable thing to do, as I verified that after addressing the three (minor) issues that the linter shows right now, the rest of the linters run without issues.

@jmhbnz, correct me if I'm wrong, but I don't think we would want to merge the PR if it would break the CI.

[jmhbnz]

I don't think we would want to merge the PR if it would break the CI.

Absolutely - we generally don't merge unless tests are passing, including static analysis.

[tico88612]

What kind of problem is this? I need some ideas to resolve this.

https://github.com/etcd-io/etcd/actions/runs/8655015103/job/23733280841?pr=17770#step:10:24

[ivanvc]

What kind of problem is this? I need some ideas to resolve this.

https://github.com/etcd-io/etcd/actions/runs/8655015103/job/23733280841?pr=17770#step:10:24

Hey @tico88612, running make fix-bom (and committing bill-of-materials.json) should fix it.

[tico88612]

What kind of problem is this? I need some ideas to resolve this.
https://github.com/etcd-io/etcd/actions/runs/8655015103/job/23733280841?pr=17770#step:10:24

Hey @tico88612, running make fix-bom (and committing bill-of-materials.json) should fix it.

Running make fix-bom doesn't work unless I delete those two lines.

[ivanvc]

Running make fix-bom doesn't work unless I delete those two lines.

See #17770 (comment)

[ivanvc]

@ahrtr PTAL :)

[ahrtr]

LGTM

Thank you!

[ivanvc]

Thanks @tico88612! Giving my thumbs up. I'm not sure if James will have the capacity to review this.

[ivanvc]

@siyuanfoundation, just a heads up of commit e3c1812. I hope you used that argument initially and then dropped it, so while technically, it won't affect the current behavior, maybe you wanted to use the tab somewhere in that method.

[siyuanfoundation]

@siyuanfoundation, just a heads up of commit e3c1812. I hope you used that argument initially and then dropped it, so while technically, it won't affect the current behavior, maybe you wanted to use the tab somewhere in that method.

It was used initially but no longer needed. Thanks for the heads up!