gofail: show error messages returned by gofail HTTP endpoints #17842
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @henrybear327. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign |
henrybear327
force-pushed
the
gofail/show_req_error_msg
branch
2 times, most recently
from
82fb546
to
b3bba0d
Compare
henrybear327
force-pushed
the
gofail/show_req_error_msg
branch
from
b3bba0d
to
1488d0c
Compare
ahrtr
reviewed
Apr 24, 2024
|
/ok-to-test |
henrybear327
force-pushed
the
gofail/show_req_error_msg
branch
3 times, most recently
from
de7b70a
to
a9485dd
Compare
fuweid
reviewed
Apr 26, 2024
henrybear327
force-pushed
the
gofail/show_req_error_msg
branch
from
a9485dd
to
d692cdf
Compare
Upon HTTP request error from fetchFailpointsBody, PUT and DELETE, all of them will return an error message, which would be nice for debugging if displayed. Simplify `Enabled()` logic (linter suggestion) Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327
force-pushed
the
gofail/show_req_error_msg
branch
from
d692cdf
to
1335768
Compare
ahrtr
approved these changes
Apr 28, 2024
serathius
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces showing the error message returned by gofail HTTP endpoints, making debugging easier.
Also apply simplified
Enabled()logic, as suggested by the linterPlease read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.