Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support AllowedCN and AllowedHostname through config file #17861

Merged
merged 1 commit into from May 8, 2024

Conversation

clwluvw
Copy link
Contributor

@clwluvw clwluvw commented Apr 23, 2024

Allow setting AllowedCN and AllowedHostname tls fields through the config file for peer transport security.

Closes: #17867

@k8s-ci-robot
Copy link

Hi @clwluvw. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahrtr
Copy link
Member

ahrtr commented Apr 24, 2024

Note there are already two flags,

  • --peer-cert-allowed-hostname
  • --host-whitelist

Please raise an issue to clarify your use case(s) if you still think it's necessary.

@ahrtr ahrtr closed this Apr 24, 2024
@clwluvw
Copy link
Contributor Author

clwluvw commented Apr 24, 2024

through config file

Caution: If you mix-and-match configuration options, then the following rules apply.
Command-line flags take precedence over environment variables.
If you provide a configuration file all command-line flags and environment variables are ignored.

@ahrtr ahrtr reopened this Apr 24, 2024
@ahrtr
Copy link
Member

ahrtr commented Apr 24, 2024

through config file

Sorry, I missed that.

@serathius
Copy link
Member

/retest

@clwluvw
Copy link
Contributor Author

clwluvw commented Apr 24, 2024

The failure on apt update might be related to the current inc 🤔 https://www.githubstatus.com/incidents/7txcg0j03kkg

@ivanvc
Copy link
Member

ivanvc commented Apr 24, 2024

/retest

@ivanvc
Copy link
Member

ivanvc commented Apr 24, 2024

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @clwluvw

Note: If you have time please add a commented out example to the sample config file showing how these fields can be supplied: https://github.com/etcd-io/etcd/blob/main/etcd.conf.yml.sample

@clwluvw
Copy link
Contributor Author

clwluvw commented May 2, 2024

Note: If you have time please add a commented out example to the sample config file showing how these fields can be supplied: https://github.com/etcd-io/etcd/blob/main/etcd.conf.yml.sample

Done.

@jmhbnz jmhbnz requested a review from ahrtr May 5, 2024 20:33
server/embed/config_test.go Outdated Show resolved Hide resolved
server/embed/config_test.go Outdated Show resolved Hide resolved
@clwluvw clwluvw force-pushed the cn-hostname-configfile branch 2 times, most recently from d73d4c7 to 381d225 Compare May 7, 2024 20:19
server/embed/config_test.go Outdated Show resolved Hide resolved
Allow setting AllowedCN and AllowedHostname tls fields through config file for peer transport security.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your first contribution.

@ahrtr ahrtr merged commit fef4236 into etcd-io:main May 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support AllowedCN and AllowedHostname through config file
6 participants