Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation comments from addressing var-naming work #17875

Merged
merged 1 commit into from Apr 30, 2024
Merged

Fix deprecation comments from addressing var-naming work #17875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/etcdserver/api/etcdhttp/health.go
View file
Open in desktop
Expand Up @@ -264,11 +264,11 @@ func (reg *CheckRegistry) RootPath() string {
}

// InstallHttpEndpoints installs the http handlers for the health checks.
//
// Deprecated: Please use (*CheckRegistry) InstallHTTPEndpoints instead.
//
//revive:disable:var-naming
//revive:disable-next-line:var-naming
func (reg *CheckRegistry) InstallHttpEndpoints(lg *zap.Logger, mux *http.ServeMux) {
//revive:enable:var-naming
reg.InstallHTTPEndpoints(lg, mux)
}

Expand Down
1 change: 1 addition & 0 deletions server/storage/datadir/datadir.go
View file
Open in desktop
Expand Up @@ -32,6 +32,7 @@ func ToSnapDir(dataDir string) string {
}

// ToWalDir returns the directory path for the member's WAL.
//
// Deprecated: use ToWALDir instead.
//
//revive:disable-next-line:var-naming
Expand Down
1 change: 1 addition & 0 deletions server/storage/util.go
View file
Open in desktop
Expand Up @@ -111,6 +111,7 @@ func CreateConfigChangeEnts(lg *zap.Logger, ids []uint64, self uint64, term, ind

// GetEffectiveNodeIdsFromWalEntries returns an ordered set of IDs included in the given snapshot and
// the entries.
//
// Deprecated: use GetEffectiveNodeIDsFromWALEntries instead.
//
//revive:disable-next-line:var-naming
Expand Down