New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e test: add schema version verification in mix_version_test. #17881
Open
siyuanfoundation
wants to merge
2
commits into
etcd-io:main
Choose a base branch
from
siyuanfoundation:downgrade-snap
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/retest |
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
April 25, 2024 23:46
506450d
to
e899f7c
Compare
serathius
reviewed
Apr 26, 2024
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
April 26, 2024 16:49
e899f7c
to
252d6d9
Compare
/retest |
serathius
reviewed
Apr 27, 2024
serathius
approved these changes
Apr 27, 2024
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
April 29, 2024 18:14
252d6d9
to
e21756b
Compare
cc @ahrtr |
/retest |
ahrtr
reviewed
Apr 29, 2024
ahrtr
reviewed
Apr 29, 2024
siyuanfoundation
force-pushed
the
downgrade-snap
branch
4 times, most recently
from
April 29, 2024 23:37
b7f6a39
to
bad484f
Compare
ahrtr
reviewed
Apr 30, 2024
The existing schemaChanges isn't flexible. Propose to add the following changes, and we can construct the the
|
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
April 30, 2024 17:31
bad484f
to
892abc2
Compare
ahrtr
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
cc @serathius to take a look |
Signed-off-by: Siyuan Zhang <sizhang@google.com>
Signed-off-by: Siyuan Zhang <sizhang@google.com>
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
May 2, 2024 22:33
892abc2
to
56fab21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17361
#17752
Verify storage version is consistent with expected at the end of tests.
Since
storageVersion
is the only field added in 3.6, there is no need to check other buckets.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.