Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback increase timeout for deactivating failpoint #18022

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

henrybear327
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @henrybear327. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@henrybear327
Copy link
Contributor Author

henrybear327 commented May 17, 2024

@ahrtr when gofail 0.2.0 is released, I will update the gofail dependencies in another PR and rebase this one on top of it!

Currently, this PR serves as double-checking the CI is still working normally after the recent gofail final changes are merged before releasing the new tag!

Update: using the new gofail commit, the CI passes normally, and rolling back the change so far looks fine!

@henrybear327
Copy link
Contributor Author

Pending PR etcd-io/gofail#69 to bump gofail to 0.2.0 (etcd-io/gofail#65 (comment))

@henrybear327
Copy link
Contributor Author

/ok-to-test

Because of etcd-io/gofail#64 being merged,
we can rollback the change.

Reference:
- etcd-io#17719

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@serathius
Copy link
Member

Don't think we need to block in integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants