Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux installation instructions #774

Merged
merged 1 commit into from May 7, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 22, 2024

I checked on pkgs.org, which distributions provide an etcd package. As @jmhbnz exposed on the biweekly triage meeting, most major distributions have outdated packages. So, I wrote the instructions for the distributions with an up-to-date version (and Homebrew).

Previews:

Fixes #767

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this proposal together @ivanvc, a few thoughts below.

content/en/docs/v3.5/install.md Outdated Show resolved Hide resolved
content/en/docs/v3.5/install.md Outdated Show resolved Hide resolved
content/en/docs/v3.5/install.md Outdated Show resolved Hide resolved
content/en/docs/v3.5/install.md Show resolved Hide resolved
@ivanvc ivanvc force-pushed the add-linux-installation-instructions branch 2 times, most recently from 641cedf to 393d219 Compare February 22, 2024 23:49
@ivanvc ivanvc mentioned this pull request Apr 25, 2024
@ivanvc ivanvc force-pushed the add-linux-installation-instructions branch from 393d219 to 33d9e4e Compare May 7, 2024 02:37
@ivanvc ivanvc requested a review from jmhbnz May 7, 2024 02:49
@ivanvc
Copy link
Member Author

ivanvc commented May 7, 2024

@jmhbnz, please take another look at the updated text. Thanks.

@ivanvc ivanvc force-pushed the add-linux-installation-instructions branch from 33d9e4e to 5ae90f2 Compare May 7, 2024 04:27
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

@jmhbnz jmhbnz requested a review from spzala May 7, 2024 04:43
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but two comments that we should address if you agree. Thanks @ivanvc

content/en/docs/v3.5/install.md Show resolved Hide resolved
content/en/docs/v3.5/install.md Outdated Show resolved Hide resolved
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the add-linux-installation-instructions branch from 5ae90f2 to c0eca1f Compare May 7, 2024 13:56
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly addressing comments @ivanvc

@spzala spzala merged commit 8e01128 into etcd-io:main May 7, 2024
5 checks passed
@ivanvc ivanvc deleted the add-linux-installation-instructions branch May 7, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Linux installation instructions
6 participants