Update "How to access etcd" page: add prereq, add h2 header, issue 790 #809
+63
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reylejano
force-pushed
the
update-etcd-tutorial
branch
2 times, most recently
from
7295c89
to
e8b8e9b
Compare
reylejano
changed the title
khanhtc1202
reviewed
Mar 19, 2024
| `put` command to write: | ||
| ## Prerequisites | ||
|
|
||
| - [etcdctl](/docs/v3.5/dev-guide/interacting_v3/) is required |
There was a problem hiding this comment.
I think we should keep this unified with other pages of this docs like this
https://github.com/etcd-io/website/blob/main/content/en/docs/v3.5/tutorials/how-to-watch-keys.md#prerequisites
reylejano
force-pushed
the
update-etcd-tutorial
branch
2 times, most recently
from
2ecae89
to
839d1e2
Compare
Signed-off-by: Rey Lejano <rlejano@gmail.com>
reylejano
force-pushed
the
update-etcd-tutorial
branch
from
839d1e2
to
4d76010
Compare
jmhbnz
reviewed
May 12, 2024
There was a problem hiding this comment.
Hey @reylejano - Is this something you were still working on? If so can you please rebase and mark ready for review when it's ready, thanks! 🙏🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #790
This PR adds the following:
Add sub-sections (## H2 headings) for: