-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Black implementation test #2112
Conversation
Idk, since you like changing formatting frequently, I thought you would like an automated system for that |
I will see whether I can change something in settings though to avoid some of the changes |
I don't like ))) I just make some updates to formatting while making valuable updates )) |
We can technically ignore apihelper-like files(also asyncio_helper); Maybe in the future I will even try to get rid of these files due to a mess over there |
May be just live things as is? 😂😂😂 |
Well, this is not my first time caring about PEP-8 - it is better if we at least try to follow it to some extent. |
I'm not in favour of carry about anything "because of" - if that does not bring any value. I do not see what value black formatting brings except "now we hava black formatting"... |
It indeed brings the value of cleaner code |
"Cleaner code" is not a value. It's "cleaner code bacause of cleaner code". |
Ok, if it does not harm project in any way - why not accept the new formatting? |
"Add value" is the good reason of bring changes. I said it many times before. I say it now. I will say it in future. |
Well then I can argue that by improving formatting, we follow suggested PEP-8 |
And this is a better practise. The reason is "adding a value", not "why not" |
"we follow suggested PEP-8" and it will give the project.... What? "Clear code"? |
"this is a better practise" - do you follow all "better practices" in your life because they are better practices? |
You should try to follow best practices as far as you can. They are created not for just existence but to help you understand your code faster |
Consistency in the code formatting for better readability is kinda worth it, provided no one really cares about the number of lines and the size of the py-files (at least in my opinion) |
@Badiboy this is how approximately black looks like