Skip to content

Commit

Permalink
tests: Stop using nyc
Browse files Browse the repository at this point in the history
There are some problems with nyc:
  * The coverage numbers aren't useful in our case because most of the
    code is executed outside the test process (the test code is mostly
    API client logic).
  * nyc messes with line numbers, which makes it much harder to debug
    problems.
  * We're seeing frequent SIGABRT crashes while nyc is printing the
    results table. I'm not sure if nyc is the cause of the crashes, or
    if it's making a race condition worse, or if the crashes have
    nothing to do with nyc, but we don't lose much by removing it so
    we might as well see if the crash frequency improves.
  • Loading branch information
rhansen authored and JohnMcLear committed Jan 29, 2021
1 parent 0897a28 commit 89bcfa2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 991 deletions.

0 comments on commit 89bcfa2

Please sign in to comment.