Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework server shutdown #4690

Merged
merged 6 commits into from
Jan 30, 2021
Merged

Rework server shutdown #4690

merged 6 commits into from
Jan 30, 2021

Commits on Jan 29, 2021

  1. server: Exit on unhandled Promise rejection

    @rhansen
    rhansen committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    e850a9e View commit details
    Browse the repository at this point in the history

  2. server: Perform init after adding uncaught exception handler 

    This avoids an unnecessary `try` block.
    @rhansen
    rhansen committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    f42a90a View commit details
    Browse the repository at this point in the history

  3. server: Refactor stop() to avoid no-async-promise-executor lint error 

    Also log when Etherpad has stopped.
    @rhansen
    rhansen committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    c5f84ab View commit details
    Browse the repository at this point in the history

  4. server: Refine process lifetime management 

    Define states and use them to properly handle multiple calls to
`start()`, `stop()`, and `exit()`. (Multiple calls to `exit()` can
happen if there is an uncaught exception or signal during shutdown.)

This should also make it easier to add support for cleanly restarting
the server after a shutdown (for tests or via an `/admin` page).
    @rhansen
    rhansen committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    aef46cd View commit details
    Browse the repository at this point in the history

  5. server: Remove all other signal listeners

    @rhansen
    rhansen committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    fdfb7c0 View commit details
    Browse the repository at this point in the history

  6. server: Use wtfnode to log reasons why node isn't exiting

    @rhansen
    rhansen committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    b7fb1e2 View commit details
    Browse the repository at this point in the history