feat/interop: create SystemConfigInterop, OptimismPortalInterop + update L1BlockInterop

[0xfuturistic]

No description provided.

[coderabbitai]

Walkthrough

The updates across various contracts in the contracts-bedrock package focus on refactoring the configuration management system. The primary change is the replacement of the setGasPayingToken function with a more versatile setConfig function. This adjustment, along with the introduction of the ConfigType enum, standardizes configuration settings across multiple contracts, enhancing flexibility and control over system parameters.

Changes

Files	Change Summary
.../OptimismPortal.sol, .../OptimismPortal2.sol, .../SystemConfig.sol, .../L1Block.sol, .../test/...	Refactored to use setConfig instead of setGasPayingToken. Added ConfigType enum and updated function calls and imports accordingly. Introduced new checks and configurations in related functions.
.../test/L1/OptimismPortal.t.sol, .../test/L1/SystemConfig.t.sol, .../test/L2/L1Block.t.sol, .../test/Specs.t.sol	Updated test files to reflect changes in main contracts, particularly the use of setConfig with ConfigType and updated import statements. Adjustments made to function calls to use encoded parameters.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Out of diff range and nitpick comments (1)

packages/contracts-bedrock/test/L1/OptimismPortal.t.sol (1)

Line range hint 699-699: Avoid using blockhash(block.number) as it always returns 0, which might not be the intended behavior.

-            proposal.outputRoot, optimismPortal.l2Oracle().nextBlockNumber(), blockhash(block.number), block.number
+            proposal.outputRoot, optimismPortal.l2Oracle().nextBlockNumber(), blockhash(block.number - 1), block.number

[coderabbitai]

Actionable comments posted: 1

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.22%. Comparing base (70c7e4d) to head (0997319).
Report is 31 commits behind head on develop.

❗ Current head 0997319 differs from pull request most recent head 12e1f95

Please upload reports for the commit 12e1f95 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10452       +/-   ##
============================================
- Coverage    42.36%   29.22%   -13.15%     
============================================
  Files           73       31       -42     
  Lines         4836     2898     -1938     
  Branches       766      614      -152     
============================================
- Hits          2049      847     -1202     
+ Misses        2680     1976      -704     
+ Partials       107       75       -32     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	?
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

[semgrep-app]

Semgrep found 3 golang_fmt_errorf_no_params findings:

• op-node/rollup/types.go
  • L416 - Triage
  • L419 - Triage
  • L422 - Triage

No fmt.Errorf invocations without fmt arguments allowed

_{Ignore this finding from golang_fmt_errorf_no_params.}

Semgrep found 1 avoid-bind-to-all-interfaces finding:

• indexer/node/client_test.go
  • L14 - Triage

Detected a network listener listening on 0.0.0.0 or an empty string. This could unexpectedly expose the server publicly as it binds to all available interfaces. Instead, specify another IP address that is not 0.0.0.0 nor the empty string.

_{Ignore this finding from avoid-bind-to-all-interfaces.}

Semgrep found 1 todos_require_linear finding:

• op-node/rollup/derive/plasma_data_source.go
  • L71 - Triage

Please create a GitHub ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

Semgrep found 1 err-nil-check finding:

• indexer/client/client.go
  • L119-123 - Triage

superfluous nil err check before return

_{Ignore this finding from err-nil-check.}

[tynes]

Going back and forth on whether or not this should revert if its already in the dep set

[semgrep-app]

Semgrep found 4 ban-common-hex2bytes findings:

• op-challenger/game/fault/contracts/faultdisputegame_test.go
  • L188 - Triage
  • L197 - Triage
  • L206 - Triage
  • L215 - Triage

Found banned use of common.Hex2Bytes. Use common.FromHex instead.

_{Ignore this finding from ban-common-hex2bytes.}

[0xfuturistic]

split up this PR into these smaller PRs:

• feat/interop: create SystemConfigInterop #10586
• feat/interop: create OptimismPortalInterop #10585
• feat/interop: update L1BlockInterop #10584