New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cross-chain-messenger.ts - Deposits some CustomGas-ERC20 token… #10469
Conversation
…s into the L2 Native chain. (Version - Testing) Deposits some CustomGas-ERC20 tokens into the L2 Native chain. (Version - Testing) Do not use approve, approveERC20 because it must be retrieved. getBridgeForTokenPair Request to add first Therefore use approval from Token directly to avoid getBridgeForTokenPair For this test function: "depositERC20Transaction" (OptimismPortalProxy) Clone: https://github.com/nidz-the-fact/op-stack-bridge-Testing-erc20-to-native Repo: https://github.com/nidz-the-fact Team ThaiChain Foundation (https://www.thaichain.io) @title Deposits some CustomGas-ERC20 tokens into the L2 Native chain. (Version - Testing) @notice Version - Testing = Therefore use approval from Token directly to avoid getBridgeForTokenPair For this test function: "depositERC20Transaction" (OptimismPortalProxy)
WalkthroughWalkthroughThe recent updates involve enhancements to the Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (1)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10469 +/- ##
===========================================
+ Coverage 42.31% 43.39% +1.08%
===========================================
Files 73 50 -23
Lines 4838 3157 -1681
Branches 766 363 -403
===========================================
- Hits 2047 1370 -677
+ Misses 2682 1678 -1004
Partials 109 109
Flags with carried forward coverage won't be shown. Click here to find out more. |
Thank you for opening this PR @nidz-the-fact! Unfortunately we are not maintaining the sdk anymore, I recommend checking out the following discussion in viem: wevm/viem#2197 |
Deposits some CustomGas-ERC20 tokens into the L2 Native chain. (Version - Testing)
Do not use approve, approveERC20 because it must be retrieved. getBridgeForTokenPair Request to add first
Therefore use approval from Token directly to avoid getBridgeForTokenPair For this test function: "depositERC20Transaction" (OptimismPortalProxy)
Clone: https://github.com/nidz-the-fact/op-stack-bridge-Testing-erc20-to-native
Repo: https://github.com/nidz-the-fact
Team ThaiChain Foundation (https://www.thaichain.io)
@title Deposits some CustomGas-ERC20 tokens into the L2 Native chain. (Version - Testing)
@notice Version - Testing = Therefore use approval from Token directly to avoid getBridgeForTokenPair For this test function: "depositERC20Transaction" (OptimismPortalProxy)