New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new CheckSecrets dripcheck #10479
Conversation
900295c
to
6c5fc4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10479 +/- ##
============================================
- Coverage 42.36% 29.22% -13.15%
============================================
Files 73 31 -42
Lines 4836 2898 -1938
Branches 766 614 -152
============================================
- Hits 2049 847 -1202
+ Misses 2680 1976 -704
+ Partials 107 75 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
WalkthroughWalkthroughThe update introduces a new Solidity contract Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files ignored due to path filters (2)
Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
packages/contracts-bedrock/src/periphery/drippie/dripchecks/CheckSecrets.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/periphery/drippie/dripchecks/CheckSecrets.sol
Outdated
Show resolved
Hide resolved
Going to wait for review from @clabby before merging |
packages/contracts-bedrock/src/periphery/drippie/dripchecks/CheckSecrets.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/periphery/drippie/dripchecks/CheckSecrets.sol
Show resolved
Hide resolved
6c5fc4a
to
6841ee3
Compare
Description
Adds a new dripcheck called CheckSecrets that acts somewhat like a timelock contract. Slightly more useful than a traditional timelock because it can be triggered by any account. Very useful if the account is actively being drained which would require using a third-party service like flashbots to circumvent.