Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-conductor: metrics #10495

Merged
merged 1 commit into from May 24, 2024
Merged

op-conductor: metrics #10495

merged 1 commit into from May 24, 2024

Conversation

zhwrd
Copy link
Contributor

@zhwrd zhwrd commented May 10, 2024

Description

Adds metrics emitted in conductor's execution and healthcheck loops including:

  • healthchecks count
  • leadership transfer count
  • sequencer / start stops
  • state changes
  • conductor loop execution times

Copy link

semgrep-app bot commented May 10, 2024

Semgrep found 3 sol-style-return-arg-fmt findings:

  • packages/contracts-bedrock/scripts/L2Genesis.s.sol
  • packages/contracts-bedrock/scripts/Deployer.sol
  • packages/contracts-bedrock/scripts/Config.sol

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Semgrep found 1 writable-filesystem-service finding:

  • ops-bedrock/docker-compose.yml

Service 'op_stack_go_builder' is running with a writable root filesystem. This may allow malicious applications to download and run additional payloads, or modify container files. If an application inside a container has to save something temporarily consider using a tmpfs. Add 'read_only: true' to this service to prevent this.

Ignore this finding from writable-filesystem-service.

Semgrep found 1 no-new-privileges finding:

  • ops-bedrock/docker-compose.yml

Service 'op_stack_go_builder' allows for privilege escalation via setuid or setgid binaries. Add 'no-new-privileges:true' in 'security_opt' to prevent this.

Ignore this finding from no-new-privileges.

@zhwrd zhwrd force-pushed the zhwrd/conductor-metrics branch 5 times, most recently from 72fefaf to 0aa66d0 Compare May 15, 2024 16:30
@zhwrd zhwrd force-pushed the zhwrd/conductor-metrics branch 3 times, most recently from 2837d2b to 774b841 Compare May 23, 2024 22:25
@zhwrd zhwrd marked this pull request as ready for review May 23, 2024 22:27
@zhwrd zhwrd enabled auto-merge May 24, 2024 15:07
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.13%. Comparing base (7ade7f2) to head (2837d2b).

Current head 2837d2b differs from pull request most recent head 1bb74bd

Please upload reports for the commit 1bb74bd to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10495       +/-   ##
============================================
+ Coverage    39.26%   55.13%   +15.87%     
============================================
  Files           27       37       +10     
  Lines         1821     2900     +1079     
  Branches       415      415               
============================================
+ Hits           715     1599      +884     
- Misses        1106     1269      +163     
- Partials         0       32       +32     
Flag Coverage Δ
cannon-go-tests 81.92% <ø> (?)
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@zhwrd zhwrd added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@zhwrd zhwrd added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@zhwrd zhwrd added this pull request to the merge queue May 24, 2024
Merged via the queue into develop with commit b3bb812 May 24, 2024
66 checks passed
@zhwrd zhwrd deleted the zhwrd/conductor-metrics branch May 24, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants