Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy-config: delete duplicate keys #10498

Closed
wants to merge 2 commits into from
Closed

Conversation

tynes
Copy link
Contributor

@tynes tynes commented May 10, 2024

Description

Based on #10166

  • fix: delete duplicate keys in base-sepolia.json
  • fix: delete duplicate keys in tsconfig.json

@tynes tynes requested review from a team as code owners May 10, 2024 18:53
@tynes tynes requested a review from maurelian May 10, 2024 18:53
@tynes tynes mentioned this pull request May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.76%. Comparing base (7daf06d) to head (462c81c).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10498      +/-   ##
===========================================
+ Coverage    42.31%   42.76%   +0.45%     
===========================================
  Files           73       69       -4     
  Lines         4838     4698     -140     
  Branches       766      754      -12     
===========================================
- Hits          2047     2009      -38     
+ Misses        2682     2580     -102     
  Partials       109      109              
Flag Coverage Δ
cannon-go-tests 81.59% <ø> (ø)
chain-mon-tests ?
common-ts-tests 26.72% <ø> (ø)
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@tynes tynes closed this May 16, 2024
@tynes tynes deleted the delete_duplicate_keys branch May 16, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants