CI: Add Link Checker #5361
CI: Add Link Checker #5361
Conversation
|
A critical exception has occurred: |
|
The commit ebde4a7 (as a parent of 8164187) contains errors. Please inspect the Run Summary for details. |
|
The commit 4c7466e (as a parent of d4da2fe) contains errors. Please inspect the Run Summary for details. |
|
The commit 75a7d6e (as a parent of 6b6e8ef) contains errors. Please inspect the Run Summary for details. |
|
The commit 7104292 (as a parent of 5386951) contains errors. Please inspect the Run Summary for details. |
|
The commit d54fd8a (as a parent of 1d44075) contains errors. Please inspect the Run Summary for details. |
|
The commit 8254fce (as a parent of d93d767) contains errors. Please inspect the Run Summary for details. |
|
The commit 957d8e5 (as a parent of 3ac9d65) contains errors. Please inspect the Run Summary for details. |
|
The commit a0f2c88 (as a parent of 6097f32) contains errors. Please inspect the Run Summary for details. |
|
Well, that fixed it. I've submitted a PR to their repo: gaurav-nelson/github-action-markdown-link-check#148 |
Pandapip1
changed the title
|
@MicahZoltu how about this CI is added alongside HTMLProofer, but have HTMLProofer not required and this one required? That way if there is an issue with Jekyll we can just not approve it, but for irrelevant PRs we don't have to worry? |
Pandapip1
changed the title
|
Reopening, since the decision that was made was on a previous revision of this PR that replaced the jekyll action. |
Pandapip1
changed the title
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
Would still like this merged. |
Pandapip1
changed the title
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
@SamWilsn what do you think of this? Personally, I would find it helpful because of the annotations. |
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
Since this is in addition to the legacy link checker, I'm good to try this out. I'll revert if I see any problems. |
This adds another action that checks links much quicker than htmlproofer does, and works with GitHub's automatic file annotations (which htmlproofer does not and can not).
Why the redundant check? Faster feedback to authors writing in real-time, and the ability to actually see the correct file and line numbers instead of having to guess. Fixing htmlproofer errors is a pain.
This does not replace htmlproofer.